Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC-2648] - Filter fixes: Dropdown, Text #1286

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

rahmanunver
Copy link
Contributor

@rahmanunver rahmanunver commented Oct 25, 2024

Pull request type

Bug fix (non-breaking change which fixes an issue)


Description

Fixes "Reset All Filters" not working for dropdown and grid-wide text filter.

What should be covered while testing?

Grid wide text filter and a dropdown filter should be able to reset its relevant Datagrid's filtered results.

@rahmanunver rahmanunver requested a review from a team as a code owner October 25, 2024 14:50
@rahmanunver rahmanunver changed the title [WC-2648] - [WC-2648] - Dropdown filter reset fix - WIP Oct 25, 2024
@rahmanunver rahmanunver changed the title [WC-2648] - Dropdown filter reset fix - WIP [WC-2648] - Filter fixes: Dropdown, Text Oct 29, 2024
@gjulivan
Copy link
Collaborator

changelog

@rahmanunver rahmanunver force-pushed the fix/WC-2648_dropdown_filter_reset branch from d2caa42 to fec1f9b Compare October 29, 2024 13:21
Copy link
Collaborator

@iobuhov iobuhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
But need rebase and unit test fixes

@rahmanunver rahmanunver force-pushed the fix/WC-2648_dropdown_filter_reset branch 2 times, most recently from 58888ff to 16a330d Compare October 30, 2024 09:19
@rahmanunver rahmanunver force-pushed the fix/WC-2648_dropdown_filter_reset branch from dc1b085 to e668108 Compare October 30, 2024 10:11
Copy link
Collaborator

@iobuhov iobuhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gjulivan gjulivan merged commit 0f91f65 into main Oct 31, 2024
16 checks passed
@gjulivan gjulivan deleted the fix/WC-2648_dropdown_filter_reset branch October 31, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants