[WC-2678]: Add playground to Custom Chart #1436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelreichert
force-pushed
the
feat/WC-2678-custom-chart-dev-mode
branch
from
711ae37 to
67e08d6
Compare
samuelreichert
changed the title
samuelreichert
force-pushed
the
feat/WC-2678-custom-chart-dev-mode
branch
from
67e08d6 to
b23e744
Compare
… data to chart data
samuelreichert
force-pushed
the
feat/WC-2678-custom-chart-dev-mode
branch
from
b23e744 to
1f25272
Compare
iobuhov
requested changes
Feb 18, 2025
| import { BaseControllerHost } from "@mendix/widget-plugin-mobx-kit/BaseControllerHost"; | ||
| import { ResizeController } from "./ResizeController"; | ||
|
|
||
| export class Host extends BaseControllerHost { |
There was a problem hiding this comment.
"Host" is too generic, can we rename it to "CustomChartControllerHost"?
| @@ -1,19 +1,30 @@ | |||
| import { EditorStoreState, PlaygroundData } from "@mendix/shared-charts/main"; | |||
There was a problem hiding this comment.
I think we need extract some logic from this hook into controllers. Also resize logic is duplicated in ResizeController.
There was a problem hiding this comment.
- We should minimize usage of debounce
- Merging props (updateData) can be done in separate function/module
- Same about managing PlotlyChart
|
|
||
| class PropsAtom<T> { | ||
| constructor(public props: T) { | ||
| makeObservable(this, { props: observable.struct, setProps: action }); |
There was a problem hiding this comment.
Make sure to copy code from my branch, I updated this class and added some comment in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description