Update include dirs for linux and osx #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -28,9 +28,10 @@ | |||
| if 'linux' in _platform: | |||
| extra_compile_args += ['-fopenmp'] | |||
| extra_link_args += ['-fopenmp'] | |||
|
|
|||
| include_dirs += ['/usr/include/eigen3', '/usr/include/libxml2'] | |||
There was a problem hiding this comment.
These are not useful hardcoded paths as they assume that eigen and libxml have been installed in those locations. However, if you are not using conda I could simply the specification of these paths by adding setup.py options for settings them? You could also just set CFLAGS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing header files when compiling in Linux and osx