Add system-info callback #15
Conversation
gabriel-samfira
requested review from
bavarianbidi,
maigl,
rafalgalaw and
H777K
as code owners
gabriel-samfira
force-pushed
the
enable-system-info-callback
branch
3 times, most recently
from
2745982 to
e770fb0
Compare
| OS_NAME=${NAME:-""} | ||
| OS_VERSION=${VERSION_ID:-""} |
There was a problem hiding this comment.
Just thinking about if we could set some meaningful default values for $NAME and $VERSION_ID maybe during build as ENV in the Dockerfile. Then a user could still overwrite these in their podTemplateSpec in the provdider config if needed.
There was a problem hiding this comment.
All of this stuff is strictly informational. It's nice to have, but not strictly necessary in terms of functionality. Simply put, it has no baring on functionality, but if a user does a:
garm-cli runner show <runner ID>that command will show the real OS and version, not something we infer from the image itself.
This was always the way I hoped this information would be sent upstream (runners would send that info as part of their installation process), but only now got around to doing it.
The idea is that by default, it should be fine to have an empty string for this stuff. But if we can safely determine the OS and version , we should send that to garm.
The /etc/os-release file has been available for a very long time. So I expect it to be present in any container image that is based of any OS that;s not scratch.
|
Thanks for the contribution @gabriel-samfira! Would it make sense to add this callback to the summerwind image as well and if so could you add it there too? :) |
not sure. Will look at that image as well. We sould theoretically do it there as well before we delegate the rest of the entrypoint execution to the default one. Will have a look later this week (traveling ATM) |
A new callback is available in garm which allows runners to send info about themselves from userdata. This new callback allows instances to report their os_name, os_version and the GH agent_id. See cloudbase/garm#200 This change allso makes sure that curl is installed in the image, otherwise the userdata will never work. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
gabriel-samfira
force-pushed
the
enable-system-info-callback
branch
from
e770fb0 to
36c6ea1
Compare
|
sorry for the delay on this. I added the system info code to the summerwind image as well. It now shows up as "Ubuntu 22.04".
|
A new callback is available in garm which allows runners to send info about themselves while installing. This new callback allows instances to report their os_name, os_version and the GH agent_id.
See cloudbase/garm#200
This change also makes sure that curl is installed in the image, otherwise the entrypoint will fail.