Change width to a float type

mercurymedia · Dec 11, 2023 · d0b8682 · d0b8682
1 parent 9228781
commit d0b8682
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/ELM_CHANGELOG.md b/ELM_CHANGELOG.md
@@ -1,5 +1,9 @@
 # Elm Changelog
 
+## [20.0.0]
+
+- Convert width from an `Int` to a `Float` type on the `ColumnSettings` and `ColumnState`. This fixes an issue where a column with a float width would fail the ColumnState decoder.
+
 ## [19.0.0]
 
 - Added `flex`, `pivot`, `pivotIndex`, `rowGroupIndex`, `sort`, and `sortIndex` to `ColumnSettings`

diff --git a/elm.json b/elm.json
@@ -3,7 +3,7 @@
     "name": "mercurymedia/elm-ag-grid",
     "summary": "AgGrid integration for Elm",
     "license": "MIT",
-    "version": "19.0.0",
+    "version": "20.0.0",
     "exposed-modules": [
         "AgGrid.ContextMenu",
         "AgGrid.Expression",

diff --git a/src/AgGrid.elm b/src/AgGrid.elm
@@ -339,7 +339,7 @@ type alias ColumnSettings =
     , valueGetter : Maybe String
     , valueParser : Maybe String
     , valueSetter : Maybe String
-    , width : Maybe Int
+    , width : Maybe Float
     , wrapHeaderText : Bool
     }
 
@@ -365,7 +365,7 @@ type alias ColumnState =
     , rowGroupIndex : Maybe Int
     , sort : Maybe String
     , sortIndex : Maybe Int
-    , width : Int
+    , width : Float
     }
 
 
@@ -1129,7 +1129,7 @@ columnDefEncoder gridConfig columnDef =
         , ( "width"
           , case columnDef.settings.width of
                 Just width ->
-                    Json.Encode.int width
+                    Json.Encode.float width
 
                 Nothing ->
                     Json.Encode.null
@@ -1152,7 +1152,7 @@ columnStateDecoder =
         |> DecodePipeline.optional "rowGroupIndex" (Decode.nullable Decode.int) Nothing
         |> DecodePipeline.optional "sort" (Decode.nullable Decode.string) Nothing
         |> DecodePipeline.optional "sortIndex" (Decode.nullable Decode.int) Nothing
-        |> DecodePipeline.required "width" Decode.int
+        |> DecodePipeline.required "width" Decode.float
 
 
 {-| Decoder for the current column states.
@@ -1208,7 +1208,7 @@ columnStateEncoder columnState =
         , ( "rowGroupIndex", encodeMaybe Json.Encode.int columnState.rowGroupIndex )
         , ( "sort", encodeMaybe Json.Encode.string columnState.sort )
         , ( "sortIndex", encodeMaybe Json.Encode.int columnState.sortIndex )
-        , ( "width", Json.Encode.int columnState.width )
+        , ( "width", Json.Encode.float columnState.width )
         ]