Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pinning to autoGroupRow #50

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

maxhille
Copy link
Contributor

@maxhille maxhille commented Feb 6, 2024

autoGroupColumnDef can do a lot more than we have available right now. According to the docs[0] is is a ColumnDef. For now all I would need is the pinning so I propose to just add that in this PR. I also activated the pinning in the grouping example.

[0] https://www.ag-grid.com/angular-data-grid/grid-options/#reference-rowGrouping-autoGroupColumnDef

Copy link
Collaborator

@hingew hingew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry in to the ELM_CHANGELOG.md and bump the elm package version?

@maxhille maxhille force-pushed the autogrouprow-pinning branch from 610d8a2 to 3867227 Compare February 13, 2024 10:02
@hingew hingew merged commit bdffdf2 into mercurymedia:main Feb 14, 2024
1 check passed
@maxhille maxhille deleted the autogrouprow-pinning branch March 11, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants