Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6262 - Fixed faces positioning in journey diagram #6263

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nghtlinh
Copy link

@nghtlinh nghtlinh commented Feb 7, 2025

📑 Summary

This PR fixes the issue where faces in the Journey Diagram were not constrained below the horizontal activity line.

Resolves #6262

📏 Design Decisions

  • Added an alert dialogue for task score inputs greater than 5, informing users of the valid range.
  • Automatically reset face height to match the highest face with a task score of 5.
  • Ensured all faces remained below the horizontal activity line.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • [] 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 7a4c74e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Feb 7, 2025
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 7a4c74e
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67a67682e495c70008c77cb2
😎 Deploy Preview https://deploy-preview-6263--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6263
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6263
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6263
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6263

commit: 7a4c74e

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 4.47%. Comparing base (8dd0e7a) to head (7a4c74e).

Files with missing lines Patch % Lines
...kages/mermaid/src/diagrams/user-journey/svgDraw.js 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6263   +/-   ##
=======================================
  Coverage     4.47%   4.47%           
=======================================
  Files          385     384    -1     
  Lines        54191   54187    -4     
  Branches       598     623   +25     
=======================================
  Hits          2425    2425           
+ Misses       51766   51762    -4     
Flag Coverage Δ
unit 4.47% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/mermaid/src/diagrams/user-journey/svgDraw.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@nghtlinh
Copy link
Author

nghtlinh commented Feb 7, 2025

@sidarthv96 Hey Sid! Our team (@nghtlinh @megantriplett @udvale) has been working on issue #6262. We added an alert dialog to let users know that the valid task score range for the journey diagram is 1-5. Also, we set the height for all tasks to 300. Does this match Mermaid's expected behavior? Let us know if you have any suggestions!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faces in Journey Diagram Out of Bound
1 participant