-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6262 - Fixed faces positioning in journey diagram #6263
base: develop
Are you sure you want to change the base?
6262 - Fixed faces positioning in journey diagram #6263
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6263 +/- ##
=======================================
Coverage 4.47% 4.47%
=======================================
Files 385 384 -1
Lines 54191 54187 -4
Branches 598 623 +25
=======================================
Hits 2425 2425
+ Misses 51766 51762 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@sidarthv96 Hey Sid! Our team (@nghtlinh @megantriplett @udvale) has been working on issue #6262. We added an alert dialog to let users know that the valid task score range for the journey diagram is 1-5. Also, we set the height for all tasks to 300. Does this match Mermaid's expected behavior? Let us know if you have any suggestions! ![]() |
📑 Summary
This PR fixes the issue where faces in the Journey Diagram were not constrained below the horizontal activity line.
Resolves #6262
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.