-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Change SequenceDB to class based architecture. #6272
Refactor: Change SequenceDB to class based architecture. #6272
Conversation
…to messages during parsing.
…saurabh/refactor/convert-sequenceDb-to-class
🦋 Changeset detectedLatest commit: 5857953 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6272 +/- ##
=======================================
Coverage 4.46% 4.46%
=======================================
Files 385 385
Lines 54276 54275 -1
Branches 598 598
=======================================
Hits 2425 2425
+ Misses 51851 51850 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The this.setWrap(getConfig().wrap);
in the constructor seems to be the only thing I'm a bit nervous about, the rest of the PR seems good to me (as long as the visual regression tests come back green ✔️)
@aloisklink i think we can refactor it into separate PR |
@saurabhg772244 please sync with develop, argos should work now. |
…saurabh/refactor/convert-sequenceDb-to-class
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…saurabh/refactor/convert-sequenceDb-to-class
📑 Summary
diagramObject.db
is called.Resolves #
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.