Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packageManager in package.json #379

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Add packageManager in package.json #379

merged 6 commits into from
Jan 23, 2025

Conversation

KomelT
Copy link
Contributor

@KomelT KomelT commented Jan 23, 2025

No description provided.

@KomelT
Copy link
Contributor Author

KomelT commented Jan 23, 2025

@Hunter275 in #377 there was an error still without version: latest and with a defined "packageManager": "[email protected]", saying "You can define version in CI and in package.json". But version was defined just in package.json. I created another PR for that to test if error is same on "clean" PR. And error is the same...

@KomelT
Copy link
Contributor Author

KomelT commented Jan 23, 2025 •
edited
Loading

... i might was looking at wrong CI file ...

ci.yaml is called only in master branch.
pr.yaml is called only in PR.

I also removed pnpm version latest from pr.yaml

@KomelT
Copy link
Contributor Author

KomelT commented Jan 23, 2025

This is ready to be merged

@Hunter275 Hunter275 merged commit cf79f3b into meshtastic:master Jan 23, 2025
3 checks passed
@KomelT KomelT deleted the add-package-manager branch January 23, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KomelT @Hunter275