Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all "Open in Colab" absolute paths #850

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

connortreacy
Copy link
Contributor

What does this PR do?

Fixes all Colab links that were broken after the refactor and rebrand.

Feature/Issue validation/testing

  • Tested all the links in the notebook preview before committing, confirmed they load the correct notebook.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 🎉!

@varunfb varunfb self-assigned this Jan 16, 2025
@varunfb varunfb self-requested a review January 16, 2025 14:19
A preview image in this readme 404s so removing the preview altogether.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-30 at 10.53.54 AM.png
is broken in colab, note to self

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct link is https://colab.research.google.com/github/meta-llama/llama-cookbook/blob/main/getting-started/build_with_Llama_3_2.ipynb

Copy link
Contributor

@IgorKasianenko IgorKasianenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All links work

@connortreacy connortreacy merged commit 258052f into main Jan 16, 2025
4 checks passed
@connortreacy connortreacy deleted the colab-links-post-refactor branch January 16, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants