Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_generation.py: Parameterize text model tests and add edge case #224

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor test_generation.py: Parameterize text model tests and add edge case #224

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23f5db9
Update test_generation.py
borgesenioc Nov 20, 2024
9bcd80e
Merge pull request #1 from borgesenioc/borgesenioc-patch-1
borgesenioc Nov 20, 2024
be55dab
Merge branch 'meta-llama:main' into main
borgesenioc Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions models/llama3/tests/api/test_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,10 @@

import os
import unittest

from pathlib import Path

import numpy as np
import pytest
from llama_models.llama3.api.datatypes import ImageMedia, SystemMessage, UserMessage

from llama_models.llama3.reference_impl.generation import Llama
from PIL import Image as PIL_Image

Expand Down Expand Up @@ -42,33 +39,44 @@ class TestTextModelInference(unittest.TestCase):
def setUpClass(cls):
cls.generator = build_generator("TEXT_MODEL_CHECKPOINT_DIR")

def test_run_generation(self):
dialogs = [
@pytest.mark.parametrize(
"dialogs",
[
[
SystemMessage(content="Always answer with Haiku"),
UserMessage(content="I am going to Paris, what should I see?"),
[
SystemMessage(content="Always answer with Haiku"),
UserMessage(content="I am going to Paris, what should I see?"),
],
[
SystemMessage(content="Always answer with emojis"),
UserMessage(content="How to go from Beijing to NY?"),
],
],
[
SystemMessage(
content="Always answer with emojis",
),
UserMessage(content="How to go from Beijing to NY?"),
[
SystemMessage(content="Always answer in riddles"),
UserMessage(content="What has keys but can't open locks?"),
]
],
]
],
)
def test_run_generation(self, dialogs):
for dialog in dialogs:
result = self.__class__.generator.chat_completion(
dialog,
temperature=0,
logprobs=True,
)

out_message = result.generation
self.assertTrue(len(out_message.content) > 0)
shape = np.array(result.logprobs).shape
# assert at least 10 tokens
self.assertTrue(shape[0] > 10)
self.assertEqual(shape[1], 1)

def test_empty_dialog(self):
with self.assertRaises(ValueError):
self.__class__.generator.chat_completion([], temperature=0)


class TestVisionModelInference(unittest.TestCase):

Expand Down Expand Up @@ -106,10 +114,8 @@ def test_run_generation(self):
temperature=0,
logprobs=True,
)

out_message = result.generation
self.assertTrue(len(out_message.content) > 0)
shape = np.array(result.logprobs).shape
# assert at least 10 tokens
self.assertTrue(shape[0] > 10)
self.assertEqual(shape[1], 1)