Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect completion() signature for Databricks provider #236

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

terrytangyuan
Copy link
Contributor

@terrytangyuan terrytangyuan commented Oct 11, 2024

This fixes the following protocol compliance check:

Method completion incompatible proto: {'logprobs', 'model', 'sampling_params', 'stream', 'content'} vs. obj: {'request'}
...
    check_protocol_compliance(impl, protocols[provider_spec.api])
  File "/app/llama-stack-source/llama_stack/distribution/resolver.py", line 321, in check_protocol_compliance
    raise ValueError(
ValueError: Provider `remote::databricks (Api.inference)` does not implement the following methods:
[('completion', 'signature_mismatch')]

Also fixed some issues identified by pre-commit checks.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 11, 2024
Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!!

@ashwinb ashwinb merged commit 2128e61 into meta-llama:main Oct 11, 2024
4 checks passed
@terrytangyuan terrytangyuan deleted the fix-db-provider branch October 11, 2024 16:10
@terrytangyuan
Copy link
Contributor Author

@ashwinb You might want to get #237 in as well to prevent this from happening going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants