-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added implementations for get_agents_session, delete_agents_session and delete_agents #267
Added implementations for get_agents_session, delete_agents_session and delete_agents #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have some minor comments. It would be good to add a test or two? See the tests in providers/tests/agents/test_agents.py
-- I would suggest making another file for just testing agent persistence (which is what this PR mostly targets.)
Will make another PR for that if thats okay with you. |
Made formatting changes shown in pre-commit @ashwinb |
Merged, thanks! |
Added implementations for not implemented methods for agents