Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementations for get_agents_session, delete_agents_session and delete_agents #267

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

cheesecake100201
Copy link
Contributor

Added implementations for not implemented methods for agents

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 18, 2024
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have some minor comments. It would be good to add a test or two? See the tests in providers/tests/agents/test_agents.py -- I would suggest making another file for just testing agent persistence (which is what this PR mostly targets.)

@cheesecake100201
Copy link
Contributor Author

cheesecake100201 commented Oct 18, 2024

Thank you. I have some minor comments. It would be good to add a test or two? See the tests in providers/tests/agents/test_agents.py -- I would suggest making another file for just testing agent persistence (which is what this PR mostly targets.)

Will make another PR for that if thats okay with you.
And what I need to test is deleting session and agent, and getting turns and steps. Please do add whatever else is needed to be tested

@cheesecake100201
Copy link
Contributor Author

Made formatting changes shown in pre-commit @ashwinb

@ashwinb ashwinb merged commit 8a01b9e into meta-llama:main Oct 22, 2024
4 checks passed
@ashwinb
Copy link
Contributor

ashwinb commented Oct 22, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants