Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill --name from llama stack build #340

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Kill --name from llama stack build #340

merged 3 commits into from
Oct 29, 2024

Conversation

ashwinb
Copy link
Contributor

@ashwinb ashwinb commented Oct 29, 2024

What does this PR do?

Simplifies llama stack build. We don't need --name and can just rely on --template as the name. When doing build from the wizard we explicitly ask for a name.

Feature/Issue validation/testing/test plan

Test with conda

Ran llama stack build tgi followed by llama stack configure tgi followed by llama stack run tgi --port 5003.

Post that ran llama stack build tgi --image-type docker which started the docker build process.

Making sure it is gone from documentation:

$ rg -- --name
distributions/meta-reference-gpu/README.md
42:docker run --network host --name mypostgres -it -p 5432:5432 -e POSTGRES_PASSWORD=mysecretpassword -e POSTGRES_USER=postgres -e POSTGRES_DB=postgres pgvector/pgvector:pg16
73:docker run -it --network host --name chromadb -p 6000:6000 -v ./chroma_vdb:/chroma/chroma -e IS_PERSISTENT=TRUE chromadb/chroma:latest

llama_stack/distribution/common.sh
13:  conda env remove --name $envname -y

distributions/ollama/README.md
62:docker run -d -v ollama:/root/.ollama -p 11434:11434 --name ollama ollama/ollama

llama_stack/providers/impls/meta_reference/inference/quantization/scripts/build_conda.sh
25:    yes | conda remove --name $ENV_NAME --all

Before submitting

  • Did you make sure to update the documentation with your changes?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 29, 2024
Copy link
Contributor

@yanxi0830 yanxi0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ashwinb ashwinb merged commit 4aa1bf6 into main Oct 29, 2024
2 checks passed
@ashwinb ashwinb deleted the simplify branch October 29, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants