Kill --name from llama stack build #340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplifies
llama stack build
. We don't need--name
and can just rely on--template
as the name. When doing build from the wizard we explicitly ask for a name.Feature/Issue validation/testing/test plan
Test with conda
Ran
llama stack build tgi
followed byllama stack configure tgi
followed byllama stack run tgi --port 5003
.Post that ran
llama stack build tgi --image-type docker
which started the docker build process.Making sure it is gone from documentation:
Before submitting