Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cache pip #349

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Do not cache pip #349

merged 1 commit into from
Oct 31, 2024

Conversation

stevegrubb
Copy link
Contributor

Pip has a 3.3GB cache of torch and friends. Do not keep this in the image. The vllm inference image should be around 6.7 GB after this. It's currently > 10 GB.

What does this PR do?

It removes the 3.3 GB cache of files that are downloaded.

@stevegrubb
Do not cache pip
467fedf 
Pip has a 3.3GB cache of torch and friends. Do not keep this in the image.
@facebook-github-bot
Copy link

Hi @stevegrubb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 31, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

ashwinb
ashwinb approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah perfect. Thank you!

@ashwinb
Copy link
Contributor

ashwinb commented Oct 31, 2024

cc @yanxi0830 just FYI

@ashwinb ashwinb merged commit f04b566 into meta-llama:main Oct 31, 2024
2 checks passed
@stevegrubb stevegrubb mentioned this pull request Nov 2, 2024
Open
@stevegrubb stevegrubb deleted the pip branch November 5, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb approved these changes

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevegrubb @facebook-github-bot @ashwinb