Fix conda env names in distribution example run files #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Self-Hosted Distribution documentation contain steps to start llama server via conda environment. If the user generates conda environment using llaama build command and template, it generate an environment with name of the distribution and not defaulyt name of local as per the example run yaml file. It will thereore fail when user tried to run the server. This PR fixes the conda env name in the run yaml file. Signed-off-by: Martin Hickey <[email protected]>
hickeyma
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
Fix formatting issue also. Signed-off-by: Martin Hickey <[email protected]>
|
Closing as fixed in 1fb6113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Self-Hosted Distribution documentation contain steps to start llama server via conda environment. If the user generates the conda environment using
llaama buildcommand with--templateflag, it generate an environment with name of the distribution and not default name oflocalas per the example run yaml files. It will therefore fail when user tried to run the server because thelocalconda env does not exist.Error similar to the following:
This PR fixes the conda env names in the distribution example run yaml files.