Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customtool's get_tool_definition to remove duplication #584

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

jeffxtang
Copy link
Contributor

What does this PR do?

Current examples would cause a lot of unnecessary painful duplication when a bunch of custom tools are expected while dealing with a real use case.

Also added pip install -U httpx==0.27.2 to avoid a httpx proxies error when running in an env with 0.28 or higher of httpx installed by default.

In short, provide a summary of what this PR does and why. Usually, the relevant context should be present in a linked issue.

  • Addresses issue (#issue)

Test Plan

Please describe:

  • tests you ran to verify your changes with result summaries.
  • provide instructions so it can be reproduced.

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 8, 2024
Copy link
Contributor

@ashwinb ashwinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ashwinb ashwinb merged commit 69a2d7b into main Dec 8, 2024
2 checks passed
@ashwinb ashwinb deleted the custom_tool_def branch December 8, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants