Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform for docker #622

Closed
wants to merge 3 commits into from
Closed

Add platform for docker #622

wants to merge 3 commits into from
+30 −6

Conversation

VladOS95-cyber
Copy link
Contributor

@VladOS95-cyber VladOS95-cyber commented Dec 13, 2024 •
edited
Loading

What does this PR do?

It is possible to specify platform param in the cmd args llama stack build --template local --image-type docker --platform linux/amd64 --name llama-stack

#253

Test Plan

Please describe:

  • tests you ran to verify your changes with result summaries.
  • provide instructions so it can be reproduced.

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 13, 2024
@VladOS95-cyber VladOS95-cyber force-pushed the add-target-platform-docker branch from 24f0f91 to 89aadb7 Compare December 16, 2024 17:27
@VladOS95-cyber VladOS95-cyber marked this pull request as ready for review December 16, 2024 17:28
@VladOS95-cyber
Copy link
Contributor Author

Hi @ashwinb @yanxi0830 @hardikjshah @dltn @raghotham! This PR is ready for a review. Please, take a look.

terrytangyuan
terrytangyuan reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed. You can add additional args via CONTAINER_OPTS

@VladOS95-cyber
Copy link
Contributor Author

I don't think this is needed. You can add additional args via CONTAINER_OPTS

Should I close this PR then?

@terrytangyuan
Copy link
Contributor

If that option works for you, then sure we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VladOS95-cyber @terrytangyuan @facebook-github-bot