-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CICD] github workflow to push nightly package to testpypi #734
Conversation
llama stack list-providers inference | ||
llama stack list-providers telemetry | ||
|
||
# TODO: add trigger for integration test workflow & docker builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @sixianyi0721 we can add a step to trigger integration test flow here using the built package
elif [ "${{ github.event_name }}" = "workflow_dispatch" ]; then | ||
echo "version=${{ inputs.version }}" >> $GITHUB_OUTPUT | ||
else | ||
echo "version=${version}.dev$(shuf -i 10000000-99999999 -n 1)" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this case happens when you run the workflow adhoc by pressing a button from the UI, for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| jq '.workflow_runs[0].id') | ||
echo "workflow_id=$run_id" >> $GITHUB_OUTPUT | ||
|
||
wait-for-workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be able to replace with this action: https://github.com/marketplace/actions/trigger-workflow-and-wait , but keeping it raw and explicit for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yanxi0830 yeah I read about some stuff; sounds good to me
fi | ||
|
||
# Get the run ID of the triggered workflow | ||
sleep 5 # Wait for workflow to be created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the number "5" recommended? curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably add a while loop here as well to wait for workflow to be created, like this action (e.g. https://github.com/convictional/trigger-workflow-and-wait/blob/f69fa9eedd3c62a599220f4d5745230e237904be/entrypoint.sh#L137-L142)
What does this PR do?
How it works / Test Plan
Get the version for release package based on how push happens.
Trigger workflow in llama-stack-client & llama-models to build a package using the version:
Wait for the workflows to finish.
After client and models package workflow finishes is pushed, update llama-stack package version & requirements. Then push a package for llama-stack.
Verify the updated package
Sources
Please link relevant resources if necessary.
Before submitting
Pull Request section?