[Test automation] generate custom test report #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sixianyi0721
force-pushed
the
ci_test_report
branch
2 times, most recently
from
76b4ace to
991f0e0
Compare
sixianyi0721
changed the title
sixianyi0721
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv and
vladimirivic
as code owners
sixianyi0721
force-pushed
the
ci_test_report
branch
3 times, most recently
from
e718395 to
e4f9175
Compare
ashwinb
reviewed
Jan 9, 2025
requirements.txt
Outdated
| @@ -11,3 +11,4 @@ requests | |||
| rich | |||
| setuptools | |||
| termcolor | |||
| pytest-html | |||
There was a problem hiding this comment.
hm, I don't think we should add this plugin by default because anyone who is not doing development won't need it. this dependency can be added only for the github workflow, or can be manually installed by any developer.
sixianyi0721
force-pushed
the
ci_test_report
branch
14 times, most recently
from
47b6cfb to
b4b9462
Compare
|
Please update the test plan / gist when you have a tabular format for the results |
Comment on lines
19
to
38
| SUPPORTED_MODELS = { | ||
| "ollama": [ | ||
| CoreModelId.llama3_1_8b_instruct.value, | ||
| CoreModelId.llama3_1_8b_instruct.value, | ||
| CoreModelId.llama3_1_70b_instruct.value, | ||
| CoreModelId.llama3_1_70b_instruct.value, | ||
| CoreModelId.llama3_1_405b_instruct.value, | ||
| CoreModelId.llama3_1_405b_instruct.value, | ||
| CoreModelId.llama3_2_1b_instruct.value, | ||
| CoreModelId.llama3_2_1b_instruct.value, | ||
| CoreModelId.llama3_2_3b_instruct.value, | ||
| CoreModelId.llama3_2_3b_instruct.value, | ||
| CoreModelId.llama3_2_11b_vision_instruct.value, | ||
| CoreModelId.llama3_2_11b_vision_instruct.value, | ||
| CoreModelId.llama3_2_90b_vision_instruct.value, | ||
| CoreModelId.llama3_2_90b_vision_instruct.value, | ||
| CoreModelId.llama3_3_70b_instruct.value, | ||
| CoreModelId.llama_guard_3_8b.value, | ||
| CoreModelId.llama_guard_3_1b.value, | ||
| ], |
There was a problem hiding this comment.
Consider getting these values dynamically instead of explicitly retrieving them individually?
@ashwinb the gist file has been updated! |
ashwinb
approved these changes
Jan 14, 2025
sixianyi0721
force-pushed
the
ci-test-new
branch
from
c352da8 to
697ce9c
Compare
sixianyi0721
force-pushed
the
ci_test_report
branch
from
8de5bac to
60d49ce
Compare
sixianyi0721
force-pushed
the
ci_test_report
branch
from
60d49ce to
01cfefe
Compare
sixianyi0721
force-pushed
the
ci-test-new
branch
from
4526b77 to
a569a92
Compare
sixianyi0721
force-pushed
the
ci_test_report
branch
from
01cfefe to
f24793d
Compare
sixianyi0721
force-pushed
the
ci-test-new
branch
2 times, most recently
from
33de00c to
901c10d
Compare
sixianyi0721
force-pushed
the
ci_test_report
branch
from
f24793d to
4ee4bbb
Compare
sixianyi0721
force-pushed
the
ci_test_report
branch
from
4ee4bbb to
9b70900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generate a test report in MD that contains two main infos:
Test Plan
For local testing, run test script in command line. See a test report being generated at tests/report.html
pytest /Users/sxyi/llama-stack/llama_stack/providers/tests/. --config=ci_test_config.yamlSee gist for output MD file
Sources
Please link relevant resources if necessary.
Before submitting
Pull Request section?