This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Feat: add a context for the proposal market/orders and remove extra fetch on cancel #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LukasDeco
commented
Mar 5, 2024
LukasDeco
commented
- Context for orderbook and user orders for proposal
- Remove extra open orders fetch on cancellation
LukasDeco
force-pushed
the
feature/orders-context
branch
from
024ae07 to
9200c56
Compare
R-K-H
suggested changes
Mar 5, 2024
There was a problem hiding this comment.
Added a bunch of thoughts and ideas, as this is starting to get into the meat and potatoes. So feel free to ignore and just keep track (as well as anyone else looking at this stuff) as this is progressing to the higher level thought of where and what state and how we're managing it.
R-K-H
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.