Add OpenGraph meta tags in artist, album and user pages #3118
+111
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"659988 listens" => "660K listens"
instead of popularity_data, which does not seem to represent the same value. Not sure where the discrepancy is, but I'm opting to put the same value in the description tag as the one we show on the web page
Only the first meta tag for og:image seems to be taken into account, and defining another one later in the head gets ignored. So don't render the default image meta tag if there is an og:image tag in the og_meta_tags props
let's not load the full size image 😅 + adding some more expected meta tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #3078
We talked SEO and OpenGraph tags recently with Ansh, and as I have been working on playlist OpenGraph tags in #3078 (as requested by a user on the forums), I thought now was the perfect time to implement OG tags in other relevant pages, while it's all fresh in my head.
Artist pages:
I haven't added a custom image yet, not exactly sure what to do.
We can't put a link to the SVGs we use in LB pages, because SVGs are not supported in OG tags.
Album pages:
User pages: