PICARD-2989: fix settings override recursion #2544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
ScriptEditorDialog
usesSettingsOverride
for locally changed settings. On repeated example file updates theSettingsOverride
would recursively reference itself. As there are many example updates on selection change this could lead to a deep recursion depth until max recursion would trigger an error.Solution
Fix SettingsOverride always referencing base settings only.
Also avoid example update calls if the script editor dialog is not visible. The edittor will update anyway once it becomes visible or gains focus.