PICARD-3013: Fix case-only renaming on case-insensitive filesystems #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phw
force-pushed
the
PICARD-3013-fix-case-inensitive-rename
branch
from
e5a6518 to
b4534aa
Compare
phw
force-pushed
the
PICARD-3013-fix-case-inensitive-rename
branch
from
b4534aa to
9c28b56
Compare
zas
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Fix case-only renaming on case-insensitive filesystems. This broke when fixing PICARD-2076 (allow long filenames) in commit 5037ce9#diff-8e9e6145ecc7e912b2d643f5064e6f196d3668bd010ffa6037775232c2aba236L520 .
Solution
Make calling
os.path.realpathoptional innormpath. It is not needed here if we assume the new filename does not exist and we want to move a file to a new name.Generally keep calling of
os.path.realpathenabled as standard, as in many cases we callnormpathon existing paths