Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI tests and package builds with Python 3.13 #2564

Merged
merged 6 commits into from
Dec 30, 2024

Conversation

phw
Copy link
Member

@phw phw commented Dec 28, 2024

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Test with Python 3.13 in CI builds, package for Windows and macOS using Python 3.13

This also contains a fix for PICARD-3016 to fix relative plugin path logging on Windows. This being broken was already the case, but now exposed by the CI tests failing with Python 3.13 due to differences in absolute path handling.

@phw phw added the Picard 3.x label Dec 28, 2024
@phw
Copy link
Member Author

phw commented Dec 28, 2024

Interesting how file path tests are failing with Python 3.13 on Windows. Not yet sure what exactly changed in Python, will investigate.

@phw
Copy link
Member Author

phw commented Dec 29, 2024

Python 3.13 has the following change:

On Windows, [isabs()](https://docs.python.org/3/library/os.path.html#os.path.isabs) no longer considers paths starting with exactly one slash (\ or /) to be absolute. (Contributed by Barney Gale and Jon Foster in [gh-44626](https://github.com/python/cpython/issues/44626).)

See https://docs.python.org/3/whatsnew/3.13.html . This definitely affects IsAbsolutePathTest, not yet sure how exactly it affects the NameFilterTestRelWin tests for the log path filters.

@phw phw force-pushed the ci-python-3.13 branch 2 times, most recently from 21c5dbf to b82ef23 Compare December 29, 2024 12:54
@phw phw requested a review from zas December 29, 2024 12:59
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit 57c9153 into metabrainz:master Dec 30, 2024
48 checks passed
@phw phw deleted the ci-python-3.13 branch December 30, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants