feat: Implement compute_shuffled_index in plonky2x and add abstracted functions for plonky2x in the utils file #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolayKostadinov21
changed the title
Co-authored-by: Aneta Tsvetkova <[email protected]>
Co-authored-by: Aneta Tsvetkova <[email protected]>
…te functions. Implement test case for 9999 input data for mainnet. Remove div_rem as builder.rem already exists
…tside compute_shuffled_index.rs
…uffled_index folder. Fix debugger.
…rking computation in bytes_slice_to_variable
Owliie
requested changes
Oct 30, 2023
casper-finality-proofs/src/compute_shuffled_index/compute_shuffled_index.rs
Outdated
Show resolved
Hide resolved
casper-finality-proofs/src/compute_shuffled_index/compute_shuffled_index.rs
Outdated
Show resolved
Hide resolved
casper-finality-proofs/src/compute_shuffled_index/compute_shuffled_index_helpers.rs
Outdated
Show resolved
Hide resolved
casper-finality-proofs/src/test_engine/wrappers/wrapper_compute_shuffled_index.rs
Outdated
Show resolved
Hide resolved
|
Run formatter for rust files |
… the new plonky2x standards
NikolayKostadinov21
changed the title
Dimo99
approved these changes
Nov 3, 2023
Owliie
requested changes
Nov 6, 2023
Xearty
reviewed
Nov 6, 2023
Xearty
reviewed
Nov 6, 2023
Xearty
reviewed
Nov 6, 2023
Xearty
reviewed
Nov 6, 2023
Xearty
reviewed
Nov 6, 2023
Xearty
reviewed
Nov 6, 2023
|
Think about moving utils.rs and variable.rs to plonky2x_extensions |
|
Rename compute_shuffled_index.rs to circuit.rs |
|
Export the circuit struct from the mod and make the circuit module private akin to weigh_justification_and_finalization |
Xearty
reviewed
Nov 6, 2023
Xearty
approved these changes
Nov 6, 2023
Owliie
requested changes
Nov 7, 2023
casper-finality-proofs/src/test_engine/wrappers/compute_shuffled_index/wrapper_mainnet.rs
Outdated
Show resolved
Hide resolved
casper-finality-proofs/src/test_engine/wrappers/compute_shuffled_index/wrapper_minimal.rs
Outdated
Show resolved
Hide resolved
Owliie
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite compute_shuffled_index in plonky2x. Implement utils folder containing abstracted functions in plonky2x.