Optimize balance_verification_circuit_data_generation, change maximum… #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetarKirov
requested review from
Dimo99,
Owliie,
Xearty and
NikolayKostadinov21
and removed request for
Dimo99
Owliie
requested changes
Nov 3, 2023
...ight-client/plonky2/circuits_executables/bin/balance_verification_circuit_data_generation.rs
Show resolved
Hide resolved
...ight-client/plonky2/circuits_executables/bin/balance_verification_circuit_data_generation.rs
Outdated
Show resolved
Hide resolved
...ight-client/plonky2/circuits_executables/bin/balance_verification_circuit_data_generation.rs
Outdated
Show resolved
Hide resolved
...ight-client/plonky2/circuits_executables/bin/balance_verification_circuit_data_generation.rs
Outdated
Show resolved
Hide resolved
...ight-client/plonky2/circuits_executables/bin/balance_verification_circuit_data_generation.rs
Outdated
Show resolved
Hide resolved
...ight-client/plonky2/circuits_executables/bin/balance_verification_circuit_data_generation.rs
Show resolved
Hide resolved
monyarm
force-pushed
the
feat/balance_verification_circuit_data_generation_improvements
branch
from
112e89a to
1527745
Compare
… level to 37, add error messages
PetarKirov
force-pushed
the
feat/balance_verification_circuit_data_generation_improvements
branch
from
1527745 to
fdb2647
Compare
Owliie
requested changes
Nov 20, 2023
| @@ -73,10 +77,9 @@ pub async fn async_main() -> Result<()> { | |||
| } | |||
|
|
|||
| let mut prev_circuit_data = first_level_data; | |||
|
|
|||
| for i in 1..38 { | |||
| let max_level = if level == None {37} else {clamp(level.unwrap(),1,37)}; | |||
There was a problem hiding this comment.
No need for clamp. Just use unwrap_or(37)
There was a problem hiding this comment.
The clamp is in case a value greater than 37 is supplied
There was a problem hiding this comment.
If the value is greater than 37, the program returns a few lines above, so the clamp is obsolete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… level to 37, add error messages