Hstaykov/circuit input generators verify attestation data #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xearty
reviewed
Mar 5, 2024
...lvm-metacraft-circuits/src/circuit_input_generators/serialization/json_serialization_utils.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
...lvm-metacraft-circuits/src/circuit_input_generators/serialization/json_serialization_utils.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
...lvm-metacraft-circuits/src/circuit_input_generators/serialization/json_serialization_utils.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
...zkllvm-metacraft-circuits/src/circuit_input_generators/serialization/serialize_attestation.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
...zkllvm-metacraft-circuits/src/circuit_input_generators/serialization/serialize_attestation.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
...metacraft-circuits/src/circuit_input_generators/verify_attestation_data_input_generators.cpp
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
...metacraft-circuits/src/circuit_input_generators/verify_attestation_data_input_generators.cpp
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
vendor/zkllvm-metacraft-circuits/src/circuit_utils/base_types.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
Xearty
reviewed
Mar 5, 2024
Xearty
reviewed
Mar 5, 2024
Xearty
reviewed
Mar 5, 2024
Xearty
reviewed
Mar 5, 2024
Xearty
reviewed
Mar 5, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_imp.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
Xearty
reviewed
Mar 5, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_imp.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 5, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_imp.h
Outdated
Show resolved
Hide resolved
HristoStaykov
force-pushed
the
hstaykov/circuit_input_generators_verify_attestation_data
branch
from
444a825 to
375a9cf
Compare
Xearty
reviewed
Mar 6, 2024
vendor/zkllvm-metacraft-circuits/src/circuit_utils/circuit_byte_utils.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 6, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_imp.h
Outdated
Show resolved
Hide resolved
HristoStaykov
force-pushed
the
hstaykov/circuit_input_generators_verify_attestation_data
branch
from
375a9cf to
6016ff0
Compare
HristoStaykov
force-pushed
the
hstaykov/circuit_input_generators_verify_attestation_data
branch
2 times, most recently
from
b6803ee to
af103cb
Compare
Xearty
reviewed
Mar 11, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_impl.h
Outdated
Show resolved
Hide resolved
Xearty
previously approved these changes
Mar 11, 2024
Owliie
requested changes
Mar 12, 2024
vendor/zkllvm-metacraft-circuits/src/circuits/compute_shuffled_index.cpp
Outdated
Show resolved
Hide resolved
...metacraft-circuits/src/circuit_input_generators/verify_attestation_data_input_generators.cpp
Outdated
Show resolved
Hide resolved
vendor/zkllvm-metacraft-circuits/src/circuit_utils/circuit_byte_utils.h
Outdated
Show resolved
Hide resolved
vendor/zkllvm-metacraft-circuits/src/circuit_utils/circuit_byte_utils.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Mar 12, 2024
vendor/zkllvm-metacraft-circuits/src/circuit_utils/circuit_byte_utils.h
Outdated
Show resolved
Hide resolved
HristoStaykov
force-pushed
the
hstaykov/circuit_input_generators_verify_attestation_data
branch
from
3f3f545 to
ff1afa8
Compare
Initial verify_attestation_data implementation. Implemented of verify_attestation_data's used structures + update of tooling version in scripts. Implemented fill_zero_hashes + static_vector fixes. Added usage of pallas::base_field_type for tocken. Initial implementation for combine_finality_votes and prove_finality. Initial test infrastructure for verify_attestation_data + const correctness. Parse json attestation to convert into struct. Test attestation fields are populated with correct data. Parse and check attestations. Added processing of all pubkeys at once with malloc-ed buffer. Use correct representation of hash in circuits. Clone test input data as part of run script.
Remove usage of std::array to comply with packed structs. Refactor std::array of Byte to static_vector of Byte. Minor fixes related to circuit build.
The zkllvm tooling will be provided in a .deb package. README update.
HristoStaykov
force-pushed
the
hstaykov/circuit_input_generators_verify_attestation_data
branch
from
ff1afa8 to
eb12318
Compare
Owliie
requested changes
Mar 13, 2024
vendor/zkllvm-metacraft-circuits/src/circuit_utils/static_vector.h
Outdated
Show resolved
Hide resolved
…ut generator. Completed attestation serialization to JSON parse-able by circuits and generating input for circuit verify_attestation_data.
HristoStaykov
force-pushed
the
hstaykov/circuit_input_generators_verify_attestation_data
branch
from
eb12318 to
f99b6a8
Compare
Owliie
approved these changes
Mar 13, 2024
Xearty
approved these changes
Mar 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
zah
deleted the
hstaykov/circuit_input_generators_verify_attestation_data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR all the necessary changes have been made to convert the JSON representation of an attestation as extracted from an Eth node and convert in into the format needed to be passed to the circuit verify_attestation_data.