Add fix variations of mf runner examples #598 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse all fix workflows from #654 and bring folders together as suggested by @blackwinter in #654 (comment) and in #662
blackwinter
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Looks good, thanks. I've marked the corresponding conversations in #662 as resolved.
metafacture-runner/src/main/dist/examples/count/subjects/references.morph.flux
Outdated
Show resolved
Hide resolved
metafacture-runner/src/main/dist/examples/gnd/references/references.fix
Outdated
Show resolved
Hide resolved
by @blackwinter Co-authored-by: Jens Wille <[email protected]>
TobiasNx
commented
Feb 5, 2025
metafacture-runner/src/main/dist/examples/marc21-to-edm/MARC21-EDM.fix.flux
Show resolved
Hide resolved
TobiasNx
commented
Feb 5, 2025
metafacture-runner/src/main/dist/examples/gnd/gnd-and-beacons/tp2json.fix
Show resolved
Hide resolved
TobiasNx
commented
Feb 5, 2025
metafacture-runner/src/main/dist/examples/transform/pica-to-marcxml/pica-to-marcxml.fix.flux
Show resolved
Hide resolved
TobiasNx
commented
Feb 5, 2025
metafacture-runner/src/main/dist/examples/transform/pica-to-marcxml/pica-to-marcxml.morph.flux
Show resolved
Hide resolved
TobiasNx
commented
Feb 5, 2025
TobiasNx
commented
Feb 5, 2025
|
There are still cases where both variants produce different output, including those where the Morph doesn't generate any output at all. |
TobiasNx
commented
Feb 5, 2025
metafacture-runner/src/main/dist/examples/gnd/crisscross-connections/extract.fix
Show resolved
Hide resolved
|
@dr0i could you have a look too? |
dr0i
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse all fix workflows from #654 and bring folders together as suggested by @blackwinter in #654 (comment) and in #662
@blackwinter would this with regard to format, naming convention meet your expectations. If so, I would have a look at your other suggestions from #662