-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust integrationtests after #127 #376
Conversation
16ea13a
to
4161687
Compare
4161687
to
ea40528
Compare
If we want to support the behaviour for creating an array with index number we should revisit this test and change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to leave the old integration test for method/fromXml/toJson/replace_allInOptionalSubfieldOfRepeatedObjectsWithAsterisk
untouched and instead add a new one for #377.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree about adding a new test, otherwise +1
0309e67
to
145e64e
Compare
145e64e
to
af806f7
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the path to the new test (Asteris -> Asterisk).
Typo fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new test name could reuse the convention from the unit tests (ImplicitArray
instead of WithoutCreatingArrayWithSetArray
).
..._allInOptionalSubfieldOfRepeatedObjectsWithAsteriskWithoutCreatingArrayWithSetArray/todo.txt
Outdated
Show resolved
Hide resolved
I changed a set_array specific integration test, I need to change it back: metafix/src/test/resources/org/metafacture/metafix/integration/record/fromJson/toJson/set_arrayWithoutValuesAndMove_fieldNewArrayOfStringsIntoArrayOfObjects/test.fix |
Since Fix can create array with
$append
since #127. I thought we could simplify our integrationtests and delete allset_arrays
that are only used to create empty arrays.As result two integration tests seem to fail now.
replace_all
now copies an element it should not:https://github.com/metafacture/metafacture-fix/blob/d18a5035d2b74508d685ec863c91e4382aff2c26/metafix/src/test/resources/org/metafacture/metafix/integration/method/fromXml/toJson/replace_allInOptionalSubfieldOfRepeatedObjectsWithAsterisk/test.fix
I opened a new issue for this: #377
Catmandu creates new arrays with index numbers.
I am not sure if I am in favour of this behaviour since this blocks the possibilty of objects with numeric names.