Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Add option "url_safe" to "to_base64" function #386

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Nov 14, 2024

Resolves #384.

@dr0i
Copy link
Member Author

dr0i commented Nov 14, 2024

Other than suggested in #384 we cannot use an option with hyphen, like the suggested url-safe. Options can use the underscore _, though.
Not sure if we want to use camel case (urlSafe? safeUrl?) or safe_url instead of url_safe ?

@TobiasNx
Copy link
Collaborator

Other than suggested in #384 we cannot use an option with hyphen, like the suggested url-safe. Options can use the underscore _, though. Not sure if we want to use camel case (urlSafe? safeUrl?) or safe_url instead of url_safe ?

url_safe as stated here: https://www.base64encode.org/

README.md Outdated Show resolved Hide resolved
@blackwinter blackwinter assigned dr0i and unassigned blackwinter Nov 14, 2024
@dr0i dr0i assigned blackwinter and unassigned dr0i Nov 14, 2024
@blackwinter blackwinter assigned dr0i and unassigned blackwinter Nov 14, 2024
@dr0i dr0i force-pushed the 384-encodeUrlToBase64 branch from 5bebf35 to d1498c0 Compare November 15, 2024 16:07
@dr0i dr0i assigned blackwinter and unassigned dr0i Nov 15, 2024
@blackwinter blackwinter assigned dr0i and unassigned blackwinter Nov 15, 2024
@dr0i dr0i force-pushed the 384-encodeUrlToBase64 branch from d1498c0 to 8fe3804 Compare November 15, 2024 16:30
@dr0i dr0i merged commit 93afd59 into master Nov 15, 2024
1 check passed
@dr0i dr0i deleted the 384-encodeUrlToBase64 branch November 15, 2024 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add option to encode a string url-safe with to_base64
3 participants