Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Use bookworm slim to build sushy-tools image #473

Merged
merged 1 commit into from
Jan 10, 2024
Merged

🌱 Use bookworm slim to build sushy-tools image #473

merged 1 commit into from
Jan 10, 2024

Conversation

elfosardo
Copy link
Member

It should reduce the final size of the image from 1.2GB to 500MB

@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2024
@elfosardo elfosardo force-pushed the reduce-sushy-tools-size branch from ddf7efa to 247ee5a Compare January 10, 2024 09:15
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2024
@elfosardo elfosardo force-pushed the reduce-sushy-tools-size branch 2 times, most recently from 4d2c4d3 to 176c9e6 Compare January 10, 2024 09:18
@elfosardo elfosardo changed the title Use bookworm slim to build sushy-tools image 🌱 Use bookworm slim to build sushy-tools image Jan 10, 2024
@elfosardo
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

tuminoid
tuminoid reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

From 1.18G to 0.57G, good finding.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@elfosardo
Copy link
Member Author

if it works :D
CI doesn't seem very happy

@elfosardo
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@elfosardo
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@elfosardo
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
@elfosardo elfosardo force-pushed the reduce-sushy-tools-size branch from 176c9e6 to fc2a53e Compare January 10, 2024 12:18
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@elfosardo
Copy link
Member Author

removing gcc at the end saves us even more bringing the image down to 350 MB

@elfosardo
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

1 similar comment
@tuminoid
Copy link
Member

/test-centos-integration-main
/test-ubuntu-integration-main

@tuminoid
Copy link
Member

tuminoid commented Jan 10, 2024 •
edited
Loading

removing gcc at the end saves us even more bringing the image down to 350 MB

342MB on my machine, even better. No need to leave compiler laying around indeed.

edit: I need to learn to read.

@tuminoid
Copy link
Member

/test-ubuntu-integration-main

CI networking has been real bad today.

@dtantsur
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@elfosardo elfosardo force-pushed the reduce-sushy-tools-size branch from fc2a53e to a0cd550 Compare January 10, 2024 14:02
@elfosardo
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

@elfosardo
Use bookworm slim to build sushy-tools image
3894323 
It should reduce the final size of the image from 1.2GB to 300MB

Signed-off-by: Riccardo Pittau <[email protected]>
@elfosardo elfosardo force-pushed the reduce-sushy-tools-size branch from a0cd550 to 3894323 Compare January 10, 2024 15:35
@elfosardo
Copy link
Member Author

/test-centos-integration-main
/test-ubuntu-integration-main

kashifest
kashifest reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rozzii
Rozzii approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 8605ad1 into metal3-io:main Jan 10, 2024
7 checks passed
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request May 3, 2024
@openshift-merge-bot
Merge pull request metal3-io#473 from MahnoorAsghar/sync
280091b 
NO-ISSUE: Merge from metal3-io/ironic-image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest left review comments

@Rozzii Rozzii Rozzii approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elfosardo @tuminoid @dtantsur @metal3-io-bot @Rozzii @kashifest