-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow independent credentials for JSON RPC #518
base: main
Are you sure you want to change the base?
Conversation
6fbe31a
to
ed7f8c5
Compare
/test metal3-ubuntu-e2e-integration-test-main |
e1f3075
to
a427363
Compare
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
It's probably not a great idea to allow users to easily access JSON RPC, so a different set of credentials is useful. Also allow the secret to be mounted directly without the convoluted auth-config format (which is an ini file in reality). Deprecate the auth-config approach (JSON RPC is the last instance where it's used). Signed-off-by: Dmitry Tantsur <[email protected]>
a427363
to
7978e68
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
It's probably not a great idea to allow users to easily access JSON RPC,
so a different set of credentials is useful.
Also allow the secret to be mounted directly without the convoluted
auth-config format (which is an ini file in reality). Deprecate
the auth-config approach (JSON RPC is the last instance where it's
used).