Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ relocate ironic-client to this repository #599

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 5, 2024

Relocate ironic-client image from ironic-client repo, which will be archived.

Ref: metal3-io/ironic-client#30

Relocate ironic-client image from ironic-client repo, which will be
archived.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Dec 5, 2024

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

This is not tested by e2e. We need to add some simple job that builds the image on PRs, not only after merges. This was not present in ironic-client repo either, so it will be done in separate PR.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

This is not tested by e2e. We need to add some simple job that builds the image on PRs, not only after merges. This was not present in ironic-client repo either, so it will be done in separate PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

tuminoid commented Dec 5, 2024

/cc @Rozzii @dtantsur

@dtantsur
Copy link
Member

dtantsur commented Dec 5, 2024

/approve
/cc @elfosardo

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@metal3-io-bot metal3-io-bot merged commit 276cd0e into metal3-io:main Dec 5, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/relocate-ironic-client branch December 5, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants