-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ relocate ironic-client to this repository #599
✨ relocate ironic-client to this repository #599
Conversation
Relocate ironic-client image from ironic-client repo, which will be archived. Signed-off-by: Tuomo Tanskanen <[email protected]>
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main This is not tested by e2e. We need to add some simple job that builds the image on PRs, not only after merges. This was not present in ironic-client repo either, so it will be done in separate PR. |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Relocate ironic-client image from ironic-client repo, which will be archived.
Ref: metal3-io/ironic-client#30