Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove ironic-lib dependency #608

Merged
merged 1 commit into from
Jan 16, 2025
Merged

⚠️ Remove ironic-lib dependency #608

merged 1 commit into from
Jan 16, 2025

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented Jan 15, 2025 •
edited
Loading

The ironic source code does not depend from ironic-lib anymore.
For more info please check [1]

[1] https://opendev.org/openstack/ironic/commit/74d239d4ebfde3e66d838c0cb74992bae0f7c00c

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2025
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2025
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 15, 2025
tuminoid
tuminoid reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is mention of ironic-lib in docs/releasing.md

@elfosardo
Remove ironic-lib dependency
f987dec 
The ironic source code does not depend from ironic-lib anymore.
For more info please check [1]

[1] https://opendev.org/openstack/ironic/commit/74d239d4ebfde3e66d838c0cb74992bae0f7c00c

Signed-off-by: Riccardo Pittau <[email protected]>
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

1 similar comment
@elfosardo
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

FYI, e2e tests are very unstable right now, since we merged some pivoting fixes in CAPM3 on Monday. We're hunting the underlying issue. One clear suspect was fixed but there is another hiding somewhere.

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
tuminoid
tuminoid reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/retest
Testing if we get lucky

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@metal3-io-bot metal3-io-bot merged commit 9f66b9d into metal3-io:main Jan 16, 2025
7 checks passed
@metal3-io-bot metal3-io-bot added this to the ironic-image - v28.0 milestone Jan 16, 2025
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Jan 22, 2025
@openshift-merge-bot
Merge pull request metal3-io#608 from iurygregory/waitress-4.13
10e188a 
OCPBUGS-43952, OCPBUGS-43960: Bump python-waitress [4.13]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@iurygregory iurygregory Awaiting requested review from iurygregory

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
ironic-image - v28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@elfosardo @tuminoid @dtantsur @metal3-io-bot