-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add named function reference support for other utility operations #313
Add named function reference support for other utility operations #313
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
5f44dac
to
10911dd
Compare
@david-waltermire I do not think this is ready for primetime but like we discussed in chat, I am not sure how to interpret certain parts of the spec and I do not know if I am "close enough" or not. |
In order to implement functions that look up names, arity, and other details for Metapath functions, we must implement processing to support named function references found from the tokenizer and lexer.
bb0e2bd
to
8f5cf4d
Compare
…tion reference unit tests to seperate found and not found tests.
@david-waltermire I will let the tests run but it seems to work after all, 🤷? |
113e57b
into
metaschema-framework:develop
Committer Notes
This PR is related to #275 and supports underlying functions as a prerequisite but does not implement any of the specified functions in that user story.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: