Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish official Docker container #40

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Sep 24, 2024

Committer Notes

Closes #22 once reviewed, approved, and merged.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?
  • Have you written new tests for your core changes, as applicable?

@aj-stein-gsa aj-stein-gsa self-assigned this Sep 24, 2024
@aj-stein-gsa aj-stein-gsa changed the base branch from main to develop September 24, 2024 03:56
@aj-stein-gsa aj-stein-gsa force-pushed the 22-publish-docker-container branch from a2f3ac0 to 8c50f0a Compare October 8, 2024 23:26
@aj-stein-gsa aj-stein-gsa reopened this Oct 8, 2024
@aj-stein-gsa aj-stein-gsa force-pushed the 22-publish-docker-container branch 9 times, most recently from 3e7199e to a7815f2 Compare October 9, 2024 02:50
@david-waltermire david-waltermire marked this pull request as ready for review November 4, 2024 02:41
@david-waltermire david-waltermire self-requested a review as a code owner November 4, 2024 02:41
pwd
ls -lha
find '.'
- if: github.repository == env.HOME_REPO && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/develop' || startsWith(github.ref, 'refs/heads/feature'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action doesn't run on main.

Suggested change
- if: github.repository == env.HOME_REPO && (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/develop' || startsWith(github.ref, 'refs/heads/feature'))
- if: github.repository == env.HOME_REPO && (github.ref == 'refs/heads/develop' || startsWith(github.ref, 'refs/heads/feature'))

Comment on lines +28 to +29
HOME_REPO: aj-stein-gsa/oscal-cli
IMAGE_NAME: aj-stein-gsa/oscal-cli-extended
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated before merging.

@david-waltermire
Copy link
Contributor

@aj-stein-gsa When are you planning to complete this work?

@aj-stein-gsa
Copy link
Contributor Author

@aj-stein-gsa When are you planning to complete this work?

Apologies that I have delayed this longer than necessary. I will complete it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish docker container
2 participants