Skip to content

Commit

Permalink
authz-v2: clean out-dated authorization implementation (istio#16119)
Browse files Browse the repository at this point in the history
  • Loading branch information
yangminzhu authored and rshriram committed Aug 9, 2019
1 parent fc69f3d commit a97b4c3
Show file tree
Hide file tree
Showing 46 changed files with 12 additions and 3,053 deletions.
8 changes: 0 additions & 8 deletions galley/pkg/config/processor/metadata/collections.gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,6 @@ var (
// IstioPolicyV1Beta1Rules is the name of collection istio/policy/v1beta1/rules
IstioPolicyV1Beta1Rules = collection.NewName("istio/policy/v1beta1/rules")

// IstioRbacV1Alpha1Authorizationpolicies is the name of collection istio/rbac/v1alpha1/authorizationpolicies
IstioRbacV1Alpha1Authorizationpolicies = collection.NewName("istio/rbac/v1alpha1/authorizationpolicies")

// IstioRbacV1Alpha1Clusterrbacconfigs is the name of collection istio/rbac/v1alpha1/clusterrbacconfigs
IstioRbacV1Alpha1Clusterrbacconfigs = collection.NewName("istio/rbac/v1alpha1/clusterrbacconfigs")

Expand Down Expand Up @@ -342,9 +339,6 @@ var (
// K8SNetworkingIstioIoV1Alpha3Virtualservices is the name of collection k8s/networking.istio.io/v1alpha3/virtualservices
K8SNetworkingIstioIoV1Alpha3Virtualservices = collection.NewName("k8s/networking.istio.io/v1alpha3/virtualservices")

// K8SRbacIstioIoV1Alpha1Authorizationpolicies is the name of collection k8s/rbac.istio.io/v1alpha1/authorizationpolicies
K8SRbacIstioIoV1Alpha1Authorizationpolicies = collection.NewName("k8s/rbac.istio.io/v1alpha1/authorizationpolicies")

// K8SRbacIstioIoV1Alpha1Clusterrbacconfigs is the name of collection k8s/rbac.istio.io/v1alpha1/clusterrbacconfigs
K8SRbacIstioIoV1Alpha1Clusterrbacconfigs = collection.NewName("k8s/rbac.istio.io/v1alpha1/clusterrbacconfigs")

Expand Down Expand Up @@ -412,7 +406,6 @@ func CollectionNames() []collection.Name {
IstioPolicyV1Beta1Handlers,
IstioPolicyV1Beta1Instances,
IstioPolicyV1Beta1Rules,
IstioRbacV1Alpha1Authorizationpolicies,
IstioRbacV1Alpha1Clusterrbacconfigs,
IstioRbacV1Alpha1Rbacconfigs,
IstioRbacV1Alpha1Servicerolebindings,
Expand Down Expand Up @@ -472,7 +465,6 @@ func CollectionNames() []collection.Name {
K8SNetworkingIstioIoV1Alpha3Serviceentries,
K8SNetworkingIstioIoV1Alpha3Sidecars,
K8SNetworkingIstioIoV1Alpha3Virtualservices,
K8SRbacIstioIoV1Alpha1Authorizationpolicies,
K8SRbacIstioIoV1Alpha1Clusterrbacconfigs,
K8SRbacIstioIoV1Alpha1Policy,
K8SRbacIstioIoV1Alpha1Rbacconfigs,
Expand Down
21 changes: 3 additions & 18 deletions galley/pkg/config/processor/metadata/metadata.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 1 addition & 17 deletions galley/pkg/config/processor/metadata/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,6 @@ collections:
proto: "istio.policy.v1beta1.Rule"
protoPackage: "istio.io/api/policy/v1beta1"

- name: "istio/rbac/v1alpha1/authorizationpolicies"
proto: "istio.rbac.v1alpha1.AuthorizationPolicy"
protoPackage: "istio.io/api/rbac/v1alpha1"

- name: "istio/rbac/v1alpha1/clusterrbacconfigs"
proto: "istio.rbac.v1alpha1.RbacConfig"
protoPackage: "istio.io/api/rbac/v1alpha1"
Expand Down Expand Up @@ -218,10 +214,6 @@ collections:
proto: "istio.policy.v1beta1.Handler"
protoPackage: "istio.io/api/policy/v1beta1"

- name: "k8s/rbac.istio.io/v1alpha1/authorizationpolicies"
proto: "istio.rbac.v1alpha1.AuthorizationPolicy"
protoPackage: "istio.io/api/rbac/v1alpha1"

- name: "k8s/rbac.istio.io/v1alpha1/clusterrbacconfigs"
proto: "istio.rbac.v1alpha1.RbacConfig"
protoPackage: "istio.io/api/rbac/v1alpha1"
Expand Down Expand Up @@ -512,7 +504,6 @@ snapshots:
- "istio/policy/v1beta1/handlers"
- "istio/policy/v1beta1/instances"
- "istio/policy/v1beta1/rules"
- "istio/rbac/v1alpha1/authorizationpolicies"
- "istio/rbac/v1alpha1/clusterrbacconfigs"
- "istio/rbac/v1alpha1/rbacconfigs"
- "istio/rbac/v1alpha1/servicerolebindings"
Expand Down Expand Up @@ -676,13 +667,7 @@ sources:
plural: "servicerolebindings"
group: "rbac.istio.io"
version: "v1alpha1"

- collection: "k8s/rbac.istio.io/v1alpha1/authorizationpolicies"
kind: "AuthorizationPolicy"
plural: "authorizationpolicies"
group: "rbac.istio.io"
version: "v1alpha1"


- collection: "k8s/rbac.istio.io/v1alpha1/rbacconfigs"
kind: "RbacConfig"
plural: "rbacconfigs"
Expand Down Expand Up @@ -975,7 +960,6 @@ transforms:
"k8s/networking.istio.io/v1alpha3/serviceentries": "istio/networking/v1alpha3/serviceentries"
"k8s/networking.istio.io/v1alpha3/sidecars": "istio/networking/v1alpha3/sidecars"
"k8s/networking.istio.io/v1alpha3/virtualservices": "istio/networking/v1alpha3/virtualservices"
"k8s/rbac.istio.io/v1alpha1/authorizationpolicies": "istio/rbac/v1alpha1/authorizationpolicies"
"k8s/rbac.istio.io/v1alpha1/policy": "istio/rbac/v1alpha1/servicerolebindings"
"k8s/rbac.istio.io/v1alpha1/rbacconfigs": "istio/rbac/v1alpha1/rbacconfigs"
"k8s/rbac.istio.io/v1alpha1/clusterrbacconfigs": "istio/rbac/v1alpha1/clusterrbacconfigs"
Expand Down
15 changes: 0 additions & 15 deletions galley/pkg/metadata/kube/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -819,21 +819,6 @@ func init() {

versions = append(versions, "v1alpha1")

b.Add(schema.ResourceSpec{
Kind: "AuthorizationPolicy",
ListKind: "AuthorizationPolicyList",
Singular: "authorizationpolicy",
Plural: "authorizationpolicies",
Versions: versions,
Group: "rbac.istio.io",
Target: metadata.Types.Get("istio/rbac/v1alpha1/authorizationpolicies"),
Converter: converter.Get("identity"),
})

versions = make([]string, 0)

versions = append(versions, "v1alpha1")

b.Add(schema.ResourceSpec{
Kind: "ClusterRbacConfig",
ListKind: "ClusterRbacConfigList",
Expand Down
6 changes: 0 additions & 6 deletions galley/pkg/metadata/types.gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,6 @@ var (
// istio/policy/v1beta1/rules metadata
IstioPolicyV1beta1Rules resource.Info

// istio/rbac/v1alpha1/authorizationpolicies metadata
IstioRbacV1alpha1Authorizationpolicies resource.Info

// istio/rbac/v1alpha1/clusterrbacconfigs metadata
IstioRbacV1alpha1Clusterrbacconfigs resource.Info

Expand Down Expand Up @@ -377,9 +374,6 @@ func init() {
IstioPolicyV1beta1Rules = b.Register(
"istio/policy/v1beta1/rules",
"type.googleapis.com/istio.policy.v1beta1.Rule")
IstioRbacV1alpha1Authorizationpolicies = b.Register(
"istio/rbac/v1alpha1/authorizationpolicies",
"type.googleapis.com/istio.rbac.v1alpha1.AuthorizationPolicy")
IstioRbacV1alpha1Clusterrbacconfigs = b.Register(
"istio/rbac/v1alpha1/clusterrbacconfigs",
"type.googleapis.com/istio.rbac.v1alpha1.RbacConfig")
Expand Down
65 changes: 0 additions & 65 deletions galley/testdata/validation/dataset.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

This file was deleted.

9 changes: 0 additions & 9 deletions galley/tools/gen-meta/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,6 @@ resources:
proto: "istio.rbac.v1alpha1.ServiceRoleBinding"
collection: "istio/rbac/v1alpha1/servicerolebindings"

- kind: "AuthorizationPolicy"
singular: "authorizationpolicy"
plural: "authorizationpolicies"
group: "rbac.istio.io"
versions:
- "v1alpha1"
proto: "istio.rbac.v1alpha1.AuthorizationPolicy"
collection: "istio/rbac/v1alpha1/authorizationpolicies"

- kind: "RbacConfig"
listKind: "RbacConfigList"
singular: "rbacconfig"
Expand Down
Loading

0 comments on commit a97b4c3

Please sign in to comment.