Skip to content

Commit

Permalink
Modify RBAC logging levels (istio#16663)
Browse files Browse the repository at this point in the history
These logs are extremely spammy and I am not sure they are useful in
day-to-day operations. If verbose debugging is enable it is easy to turn
on.
  • Loading branch information
howardjohn authored and istio-testing committed Aug 29, 2019
1 parent a1a8a56 commit f900de8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pilot/pkg/networking/plugin/authz/authorization.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,16 @@ func buildFilter(in *plugin.InputParams, mutable *plugin.MutableObjects) {
httpFilter := builder.BuildHTTPFilter()
for cnum := range mutable.FilterChains {
if mutable.FilterChains[cnum].ListenerProtocol == plugin.ListenerProtocolHTTP {
rbacLog.Infof("added HTTP filter to gateway filter chain %d", cnum)
rbacLog.Debugf("added HTTP filter to gateway filter chain %d", cnum)
mutable.FilterChains[cnum].HTTP = append(mutable.FilterChains[cnum].HTTP, httpFilter)
} else {
rbacLog.Infof("added TCP filter to gateway filter chain %d", cnum)
rbacLog.Debugf("added TCP filter to gateway filter chain %d", cnum)
mutable.FilterChains[cnum].TCP = append(mutable.FilterChains[cnum].TCP, tcpFilter)
}
}
} else {
for cnum := range mutable.FilterChains {
rbacLog.Infof("added TCP filter to filter chain %d", cnum)
rbacLog.Debugf("added TCP filter to filter chain %d", cnum)
mutable.FilterChains[cnum].TCP = append(mutable.FilterChains[cnum].TCP, tcpFilter)
}
}
Expand All @@ -113,7 +113,7 @@ func buildFilter(in *plugin.InputParams, mutable *plugin.MutableObjects) {
filter := builder.BuildHTTPFilter()
if filter != nil {
for cnum := range mutable.FilterChains {
rbacLog.Infof("added HTTP filter to filter chain %d", cnum)
rbacLog.Debugf("added HTTP filter to filter chain %d", cnum)
mutable.FilterChains[cnum].HTTP = append(mutable.FilterChains[cnum].HTTP, filter)
}
}
Expand All @@ -126,12 +126,12 @@ func buildFilter(in *plugin.InputParams, mutable *plugin.MutableObjects) {
switch mutable.FilterChains[cnum].ListenerProtocol {
case plugin.ListenerProtocolTCP:
if tcpFilter != nil {
rbacLog.Infof("added TCP filter to filter chain %d", cnum)
rbacLog.Debugf("added TCP filter to filter chain %d", cnum)
mutable.FilterChains[cnum].TCP = append(mutable.FilterChains[cnum].TCP, tcpFilter)
}
case plugin.ListenerProtocolHTTP:
if httpFilter != nil {
rbacLog.Infof("added HTTP filter to filter chain %d", cnum)
rbacLog.Debugf("added HTTP filter to filter chain %d", cnum)
mutable.FilterChains[cnum].HTTP = append(mutable.FilterChains[cnum].HTTP, httpFilter)
}
}
Expand Down

0 comments on commit f900de8

Please sign in to comment.