Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bind/publish to different addresses in non linux #425

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

mfontanini
Copy link
Owner

This makes:

  • Linux bind to 127.0.0.1 and publish on 127.255.255.255 which allows multiple listeners on the same port as expected.
  • Windows bind and publish on 127.0.0.1, which also allows multiple listeners.
  • Mac's lo interface doesn't have BROADCAST enabled, so binding multiple listeners is not supported since while we could allow binding multiple listeners, only one of them would get the packets so instead we err. Maybe there's a better way of doing this but in practice nobody's going to be running multiple presentations at once so making this more complicated provides no gain.

@mfontanini mfontanini merged commit efc8335 into master Jan 25, 2025
6 checks passed
@mfontanini mfontanini deleted the fix/udp-bind-address branch January 25, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant