Merge cockroachdb#138902

138902: roachprod-microbench: influx fails on missing benchmark r=herkolategan a=herkolategan Previously, the push to influx operation did not handle the case where it could not compute a summary between two runs due to a missing or renamed benchmark. This change adds a check to skip over the benchmark if no summaries are found. Epic: None Release note: None Co-authored-by: Herko Lategan <[email protected]>
mgartner · Jan 21, 2025 · 38b28bf · 38b28bf
2 parents 210d1f0 + 752e9d6
commit 38b28bf
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/cmd/roachprod-microbench/compare.go b/pkg/cmd/roachprod-microbench/compare.go
@@ -466,6 +466,10 @@ func (c *compare) pushToInfluxDB() error {
 		}
 
 		for idx, benchmarkName := range cs.Benchmarks {
+			if len(cs.Summaries) == 0 {
+				log.Printf("WARN: no summaries for %s", benchmarkName)
+				continue
+			}
 			sum := cs.Summaries[0][idx]
 			if !sum.Defined() {
 				continue