Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
136211: roachtest: fix db-console/cypress roachtest r=kyle-a-wong a=kyle-a-wong

Fixes a bug introduced in cockroachdb#135992 that resulted in db_console/cypress to fail due to connection timeoutes. That PR stopped the roachtest from starting up CRDB on the workload node, but the test was still using this node to run the seed queries.

Now, the seed queries are ran on a CRDB node.

Fixes: cockroachdb#136063
Epic: none
Release note: none

Co-authored-by: Kyle Wong <[email protected]>
  • Loading branch information
craig[bot] and kyle-a-wong committed Nov 26, 2024
2 parents b6bfe7b + 62505d8 commit a9f6a2e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cmd/roachtest/tests/db_console.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ func registerDbConsole(r registry.Registry) {
Suites: registry.Suites(registry.Nightly),
Randomized: false,
Run: runDbConsoleCypressMixedVersions,
Timeout: 1 * time.Hour,
Timeout: 2 * time.Hour,
})
r.Add(registry.TestSpec{
Name: "db-console/cypress",
Expand All @@ -227,7 +227,7 @@ func runDbConsoleCypress(ctx context.Context, t test.Test, c cluster.Cluster) {
c.Start(ctx, t.L(), option.DefaultStartOpts(), install.MakeClusterSettings(), c.CRDBNodes())

cypressTest := newDbConsoleCypressTest(t, c, "cypress/e2e/health-check/*.ts", seedQueries)
db, err := c.ConnE(ctx, t.L(), cypressTest.testCluster.WorkloadNode()[0])
db, err := c.ConnE(ctx, t.L(), cypressTest.testCluster.CRDBNodes()[0])
if err != nil {
t.Fatal(err)
}
Expand Down

0 comments on commit a9f6a2e

Please sign in to comment.