Assume ordered mapping to avoid unnecessary sorting (breaks backwards compat.) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This results in a nice speedup (80 it/s -> 120 it/s on my computer, for PA congressional recom runs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GerryChain's
retworkxbranch is now fast enough to warrant profiling/optimizingpcompress(the Python part of it, that is).With this change, https://github.com/mggg/GerryChain/pull/381/files#diff-da8db0188ac13cf96790b0e942fbcf3fab038487158df62d9910e450c506adbdL32-R37, we can remove the sort operation in
pcompressand rely on GerryChain to maintain this as an invariant. This PR WILL break backwards compatibility, so great care must be taken to ensure that newer versions ofpcompressare not mixed with older versions ofGerryChain.