Skip to content

Commit

Permalink
#64 fix javadoc issues
Browse files Browse the repository at this point in the history
  • Loading branch information
mgsx-dev committed Jul 25, 2022
1 parent 2df995c commit 838674e
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 11 deletions.
4 changes: 2 additions & 2 deletions gltf/src/net/mgsx/gltf/data/extensions/KHRLightsPunctual.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
import net.mgsx.gltf.scene3d.lights.SpotLightEx;

/**
* {@link net.mgsx.gltf.data.scene.GLTFNode} and {@link net.mgsx.gltf.data.GLTF} (root) extension
* @see https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_lights_punctual
* {@link net.mgsx.gltf.data.scene.GLTFNode} and {@link net.mgsx.gltf.data.GLTF} (root) extension.
* See https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_lights_punctual
*/
abstract public class KHRLightsPunctual {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import net.mgsx.gltf.data.texture.GLTFTextureInfo;

/**
* {@link net.mgsx.gltf.model.material.GLTFMaterial} extension (deprecated now)
* @see https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Archived/KHR_materials_pbrSpecularGlossiness/README.md
* {@link net.mgsx.gltf.data.material.GLTFMaterial} extension (deprecated now).
* See https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Archived/KHR_materials_pbrSpecularGlossiness/README.md
*/
public class KHRMaterialsPBRSpecularGlossiness
{
Expand Down
4 changes: 2 additions & 2 deletions gltf/src/net/mgsx/gltf/data/extensions/KHRMaterialsUnlit.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package net.mgsx.gltf.data.extensions;

/**
* {@link net.mgsx.gltf.data.material.GLTFMaterial} extension
* @see https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_materials_unlit
* {@link net.mgsx.gltf.data.material.GLTFMaterial} extension.
* See https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_materials_unlit
*/
public class KHRMaterialsUnlit {
public static final String EXT = "KHR_materials_unlit";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package net.mgsx.gltf.data.extensions;

/**
* {@link net.mgsx.gltf.model.texture.GLTFTextureInfo} extension
* @see https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_texture_transform/README.md
* {@link net.mgsx.gltf.data.texture.GLTFTextureInfo} extension.
* See https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_texture_transform/README.md
*/
public class KHRTextureTransform {
public static final String EXT = "KHR_texture_transform";
Expand Down
2 changes: 0 additions & 2 deletions gltf/src/net/mgsx/gltf/scene3d/shaders/PBRShaderProvider.java
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ protected boolean isGL3(){
* override this method in order to add your own prefix.
* @param renderable
* @param config
* @return
*/
public String createPrefixBase(Renderable renderable, PBRShaderConfig config) {

Expand Down Expand Up @@ -370,7 +369,6 @@ protected Shader createShader(Renderable renderable) {
* @param renderable
* @param config
* @param prefix
* @return
*/
protected PBRShader createShader(Renderable renderable, PBRShaderConfig config, String prefix){
return new PBRShader(renderable, config, prefix);
Expand Down
2 changes: 1 addition & 1 deletion gltf/src/net/mgsx/gltf/scene3d/utils/IBLBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ protected void disposeColorTexture(Cubemap colorTexture) {
/**
* Creates an radiance map, to be used with {@link net.mgsx.gltf.scene3d.attributes.PBRCubemapAttribute#SpecularEnv}
* generated cubemap contains mipmaps in order to perform roughness in PBR shading
* @param levels mipMapLevels how many mipmaps level, eg. 10 levels produce a 1024x1024 cubemap with mipmaps.
* @param mipMapLevels how many mipmaps level, eg. 10 levels produce a 1024x1024 cubemap with mipmaps.
* @return generated cubemap, caller is responsible to dispose it when no longer used.
*/
public Cubemap buildRadianceMap(final int mipMapLevels){
Expand Down

0 comments on commit 838674e

Please sign in to comment.