Skip to content

Commit

Permalink
configure.ac/makefile.am: Update to newer autoconf/automake format
Browse files Browse the repository at this point in the history
Resolves an issue:
configure.ac:8: warning: AM_INIT_AUTOMAKE: two- and three-arguments
change based on a patch from Vaneet Narang <[email protected]>
and Maninder Singh <[email protected]>

Add AC_CONFIG_MACRO_DIR([m4]) to configure.ac to resolve warning.

Quote AC_LIBELF_SXWORD in m4/libelf.m4 to resolve:
warning: underquoted definition of AC_LIBELF_SXWORD in m4/libelf.m4

In Makefile.am files, replace INCLUDES w/ AM_CPPFLAGS as appropriate.

Remove 'AUTOMAKE_OPTIONS = 1.4 gnu', no longer necessary.

2016-03-10  Mark Hatle <[email protected]>
        * configure.ac, m4/libelf.m4, doc/Makefile.am, gelf/Makefile.am,
          gelfx/Makefile.am, gelfx32/Makefile.am, patches/Makefile.am,
          src/Makefile.am, src/rtld/Makefile.am, testsuite/Makefile.am:
                Update to avoid autoconf/automake warnings

Signed-off-by: Mark Hatle <[email protected]>
  • Loading branch information
Mark Hatle committed Mar 22, 2016
1 parent 927979b commit 883d8b9
Show file tree
Hide file tree
Showing 12 changed files with 16 additions and 26 deletions.
6 changes: 6 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2016-03-10 Mark Hatle <[email protected]>
* configure.ac, m4/libelf.m4, doc/Makefile.am, gelf/Makefile.am,
gelfx/Makefile.am, gelfx32/Makefile.am, patches/Makefile.am,
src/Makefile.am, src/rtld/Makefile.am, testsuite/Makefile.am:
Update to avoid autoconf/automake warnings

2015-10-29 Mark Hatle <[email protected]>
Kyle McMartin <[email protected]>
Jakub Jelinek <[email protected]>
Expand Down
1 change: 0 additions & 1 deletion Makefile.am
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu
MAINT_CHARSET = latin1

ACLOCAL_AMFLAGS = -I m4
Expand Down
5 changes: 3 additions & 2 deletions configure.ac
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
dnl Process this file with autoconf to produce a configure script. -*-m4-*-
AC_INIT(src/prelink.c)
AC_INIT([prelink], [1.0])
AC_CONFIG_HEADERS(config.h)
AC_CONFIG_MACRO_DIR([m4])
AC_PREREQ(2.50) dnl Minimum Autoconf version required.
AC_CANONICAL_SYSTEM
AC_ARG_PROGRAM

AM_INIT_AUTOMAKE([prelink], [0.0])
AM_INIT_AUTOMAKE([subdir-objects gnu 1.4])

ALL_LINGUAS=

Expand Down
2 changes: 0 additions & 2 deletions doc/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu

man_MANS = prelink.8 execstack.8
EXTRA_DIST = prelink.8 execstack.8 prelink.conf
PDFLATEXINPUTS = TEXINPUTS_pdflatex=.:$(srcdir):`kpsewhich --progname=pdflatex --show-path=cnf.pdflatex`
Expand Down
4 changes: 1 addition & 3 deletions gelf/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu

DEFS = -D_GNU_SOURCE -DHAVE_CONFIG_H -Wall
AM_CFLAGS = -Wall
INCLUDES = @GELFINCLUDE@
AM_CPPFLAGS = @GELFINCLUDE@

noinst_LTLIBRARIES = libgelf.la

Expand Down
2 changes: 0 additions & 2 deletions gelfx/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu

noinst_HEADERS = gelfx.h
2 changes: 0 additions & 2 deletions gelfx32/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu

noinst_HEADERS = gelfx.h
2 changes: 1 addition & 1 deletion m4/libelf.m4
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ dnl Detect it.

dnl Written by Jakub Jelinek <[email protected]>.

AC_DEFUN(AC_LIBELF_SXWORD,
AC_DEFUN([AC_LIBELF_SXWORD],
[AC_TRY_RUN([
#include <errno.h>
#include <fcntl.h>
Expand Down
2 changes: 0 additions & 2 deletions patches/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu

EXTRA_DIST = libelf-0.7.0.patch libelf-0.7.0-hash.patch linux-2.4.10.patch
4 changes: 1 addition & 3 deletions src/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu

SUBDIRS = rtld

PKGVERSION = "\"@PKGVERSION@\""
Expand All @@ -17,7 +15,7 @@ AM_CPPFLAGS = -DSBINDIR='"@sbindir@"' -DBINDIR='"@bindir@"' \
-DEXEEXT='"$(EXEEXT)"' \
-DPKGVERSION=$(PKGVERSION) \
-DREPORT_BUGS_TO=$(REPORT_BUGS_TO)
INCLUDES = @GELFINCLUDE@
AM_CPPFLAGS += @GELFINCLUDE@

sbin_PROGRAMS = prelink
bin_PROGRAMS = execstack
Expand Down
10 changes: 4 additions & 6 deletions src/rtld/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu

PKGVERSION = "\"@PKGVERSION@\""
REPORT_BUGS_TO = "\"@REPORT_BUGS_TO@\""

Expand All @@ -15,13 +13,13 @@ AM_CPPFLAGS = -DSBINDIR='"@sbindir@"' -DBINDIR='"@bindir@"' \
-DEXEEXT='"$(EXEEXT)"' \
-DPKGVERSION=$(PKGVERSION) \
-DREPORT_BUGS_TO=$(REPORT_BUGS_TO)
INCLUDES = -I$(top_srcdir)/src @GELFINCLUDE@
AM_CPPFLAGS += -I$(top_srcdir)/src @GELFINCLUDE@

sbin_PROGRAMS = prelink-rtld

prelink_rtld_SOURCES = $(top_srcdir)/src/data.c $(top_srcdir)/src/dso.c \
$(top_srcdir)/src/canonicalize.c $(top_srcdir)/src/wrap-file.c \
$(top_srcdir)/src/reloc-info.c $(top_srcdir)/src/reloc-info.h \
prelink_rtld_SOURCES = ../data.c ../dso.c \
../canonicalize.c ../wrap-file.c \
../reloc-info.c ../src/reloc-info.h \
rtld.c ld-libs.h \
dl-hash.h dl-object.c dl-load.c \
dl-tls.c dl-version.c dl-misc.c \
Expand Down
2 changes: 0 additions & 2 deletions testsuite/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
## Process this file with automake to create Makefile.in

AUTOMAKE_OPTIONS = 1.4 gnu

DEFS = -D_GNU_SOURCE -DHAVE_CONFIG_H -Wall
AM_CFLAGS = -Wall

Expand Down

0 comments on commit 883d8b9

Please sign in to comment.