Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icon): build icon dictionary within icon bundler #761

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

fredmaggiowski
Copy link
Member

@fredmaggiowski fredmaggiowski commented Dec 12, 2024

Description

This PR is meant to ship the list of available icons, organized per-package. The purpose is being able to provide features such as listing icons for user-selection

Screenshot 2024-12-12 alle 21 31 20

[IMPORTANT] PR Checklist

  • I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

  • PR title follows the <type>(<scope>): <subject> structure

  • The PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).

    NOTE
    Some labels are used to generate release note entries: you can find the complete mapping between PR labels and release note categories here.
    For a more detailed overview of PR labels, please refer to the dedicated CONTRIBUTING section.

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

  • Changes are covered by tests
  • Changes to components are accessible and documented in the Storybook
  • Typings have been updated
  • New components are exported from the src/index.ts file
  • New files include the Apache 2.0 License disclaimer
  • The browser console does not contain errors

@fredmaggiowski fredmaggiowski requested a review from a team as a code owner December 12, 2024 20:33
@fredmaggiowski fredmaggiowski added the Icon component Icon component and hooks related activities label Dec 12, 2024
epessina
epessina previously approved these changes Dec 13, 2024
@fredmaggiowski fredmaggiowski added the enhancement New feature or request label Dec 13, 2024
@fredmaggiowski fredmaggiowski merged commit 3aca939 into main Dec 13, 2024
6 checks passed
@fredmaggiowski fredmaggiowski deleted the feat/build-icons-dictionary-for-bundle branch December 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Icon component Icon component and hooks related activities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants