Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormItem): fix style and added label decorations and extraIcon #779

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

nicmell
Copy link
Contributor

@nicmell nicmell commented Dec 19, 2024

Fix style and added label decorations and extraIcon in FormItem

Screenshot 2024-12-19 alle 16 14 44

Screenshot 2024-12-19 alle 16 15 28

FormItem
- Fixed color in label
- Added extraIcon prop to set icon in extra text
- Added docLink and tooltip in label
- Fix dependencies prop not forwarded to the antd inner component

[IMPORTANT] PR Checklist

  • I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

  • PR title follows the <type>(<scope>): <subject> structure

  • The PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).

    NOTE
    Some labels are used to generate release note entries: you can find the complete mapping between PR labels and release note categories here.
    For a more detailed overview of PR labels, please refer to the dedicated CONTRIBUTING section.

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

  • Changes are covered by tests
  • Changes to components are accessible and documented in the Storybook
  • Typings have been updated
  • New components are exported from the src/index.ts file
  • New files include the Apache 2.0 License disclaimer
  • The browser console does not contain errors

@nicmell nicmell requested a review from a team as a code owner December 19, 2024 15:18
@nicmell nicmell added enhancement New feature or request FormItem component FormItem component and hooks related activities labels Dec 19, 2024
Nicola Melloni added 2 commits December 19, 2024 16:22
fredmaggiowski
fredmaggiowski previously approved these changes Dec 20, 2024
ThisIsDemetrio
ThisIsDemetrio previously approved these changes Jan 2, 2025
@nicmell nicmell dismissed stale reviews from ThisIsDemetrio and fredmaggiowski via 2b0cac9 January 7, 2025 10:02
@ThisIsDemetrio ThisIsDemetrio merged commit 92cbd58 into main Jan 7, 2025
6 checks passed
@ThisIsDemetrio ThisIsDemetrio deleted the fix/form-item-label-decorations branch January 7, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FormItem component FormItem component and hooks related activities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants