Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Feedback): fixed style to prevent overflow errors #781

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

fedepini
Copy link
Contributor

Description

This PR has the goal of fixing a problem that was present when wrapping the Feedback component inside another component, such as Modal, where overflow was applied to content.

Feedback
- updated style

[IMPORTANT] PR Checklist

  • I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

  • PR title follows the <type>(<scope>): <subject> structure

  • The PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).

    NOTE
    Some labels are used to generate release note entries: you can find the complete mapping between PR labels and release note categories here.
    For a more detailed overview of PR labels, please refer to the dedicated CONTRIBUTING section.

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

  • Changes are covered by tests
  • Changes to components are accessible and documented in the Storybook
  • Typings have been updated
  • New components are exported from the src/index.ts file
  • New files include the Apache 2.0 License disclaimer
  • The browser console does not contain errors

@fedepini fedepini added bug Something isn't working Feedback component labels Dec 19, 2024
@fedepini fedepini self-assigned this Dec 19, 2024
@fedepini fedepini marked this pull request as ready for review December 19, 2024 16:48
@fedepini fedepini requested a review from a team as a code owner December 19, 2024 16:48
@fedepini fedepini requested a review from clabene December 19, 2024 16:48
@fedepini fedepini merged commit 5f1914b into main Dec 20, 2024
6 checks passed
@fedepini fedepini deleted the fix/fix-feedback-style branch December 20, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Feedback component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants