Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minifier rewrite #53

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

luna
Copy link
Contributor

@luna luna commented Nov 3, 2024

Addresses #26, goes through characters individually and checks for:

  • Double quotes, we simply want to find the end of the string (next double quote that isn't escaped) and copy everything it contains
  • Forward slashes to potentially find & skip comments entirely
  • Whitespace to determine whether or not one should be placed

Goes through characters individually and checks for:
- Double quotes, we simply want to find the next double quote that is not escaped and copy everything it contains
- Forward slashes to potentially find & skip comments entirely
- Whitespace to determine whether or not one should be placed
@luna luna changed the title fix: new minifier fix: minifier rewrite Nov 3, 2024
luna added 4 commits November 4, 2024 00:09
space needs to be present if the previous character is a closing square bracket so that something like `level.players[0] [[level.thing]]();` can still be treated as a function call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant