Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect types for some functions? #184

Open
ibarrae opened this issue Jun 5, 2020 · 3 comments
Open

Incorrect types for some functions? #184

ibarrae opened this issue Jun 5, 2020 · 3 comments
Labels
bug

Comments

@ibarrae
Copy link

ibarrae commented Jun 5, 2020

First of all, thanks for the library has been really helpful 🎉.

On a project I have been working, we have found out that at least getAlpha3Code and alpha2ToAlpha3 return types are undefined | string even though in index.d.ts both return types are string.
@michaelwittig
Copy link
Owner

You are right. Do you feel comfortable providing a fix?

@ibarrae
Copy link
Author

ibarrae commented Jun 8, 2020 •
edited
Loading

Sure, I can work on a fix in the upcoming days 👍. But should that be on top of #164 ? I just figured out there's a PR for this 🤔

@michaelwittig
Copy link
Owner

PR in #198

@danilofuchs danilofuchs mentioned this issue Dec 12, 2020
Closed
8 tasks
@michaelwittig michaelwittig mentioned this issue Sep 28, 2021
Closed
@osdiab osdiab mentioned this issue Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add numeric code types, make types more precise, add some types tests osdiab/node-i18n-iso-countries
2 participants
@michaelwittig @ibarrae